This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix 21666 - Remove deprecations w.r.t. real formatting for checkaction=context #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonlightSentinel
force-pushed
the
checkaction-deprecations
branch
from
075255e to
82aca72
Compare
MoonlightSentinel
requested review from
MartinNowak and
schveiguy
as code owners
...checkaction=context. These deprecations are issued when `real.sizeof = double.sizeof`. This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20759.
MoonlightSentinel
force-pushed
the
checkaction-deprecations
branch
from
82aca72 to
1c57001
Compare
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3389" |
MoonlightSentinel
changed the title
thewilsonator
approved these changes
Mar 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These deprecations are issued when real.sizeof = double.sizeof.
This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20759.