This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Github CI: Drop Ubuntu 16.04 and clang < 8 #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not providing an argument defaults to dmd-latest, which is what we want.
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3396" |
thewilsonator
approved these changes
Mar 15, 2021
|
Alright, LLVM switched their URL pattern again (10+ are now redirected to Github) so I dropped that part for now. |
|
Should be g2g, will set auto-merge if tests pass |
Geod24
force-pushed
the
github-actioins
branch
3 times, most recently
from
93129a6 to
2061a43
Compare
We're having issues due to yet another change by Github to their image, and Ubuntu 16.04 is EOL soon, so just drop it along with clang 6 and 7 which are not available on Ubuntu 18.04, the new supported LTS. Switching to Ubuntu 18.04 unfortunately triggers issue 19116, which forces us to disable 32 bits for the time being.
|
|
Thanks for the perseverance @Geod24 ! Looks like you nailed it this time. |
RazvanN7
approved these changes
Mar 15, 2021
|
Ergh, I wish you had let me time to clean up the commit :/ |
rymrg
pushed a commit
to rymrg/druntime
that referenced
this pull request
Mar 15, 2021
* Github CI: Use dmd-latest Not providing an argument defaults to dmd-latest, which is what we want. * Github CI: Remove no-longer needed workaround * Github CI: Use correct comment syntax on Windows * Github CI: Use Windows paths on Windows * Github CI: Drop Ubuntu 16.04 and clang < 8, disable 32 bits We're having issues due to yet another change by Github to their image, and Ubuntu 16.04 is EOL soon, so just drop it along with clang 6 and 7 which are not available on Ubuntu 18.04, the new supported LTS. Switching to Ubuntu 18.04 unfortunately triggers issue 19116, which forces us to disable 32 bits for the time being. * Attempt number 328349538459345
rymrg
added a commit
to rymrg/druntime
that referenced
this pull request
Mar 16, 2021
* Fix 21666 - Remove deprecations w.r.t. real formatting for... ...checkaction=context. These deprecations are issued when `real.sizeof = double.sizeof`. This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20759. * purge changelog * Github CI: Drop Ubuntu 16.04 and clang < 8 (dlang#3396) * Github CI: Use dmd-latest Not providing an argument defaults to dmd-latest, which is what we want. * Github CI: Remove no-longer needed workaround * Github CI: Use correct comment syntax on Windows * Github CI: Use Windows paths on Windows * Github CI: Drop Ubuntu 16.04 and clang < 8, disable 32 bits We're having issues due to yet another change by Github to their image, and Ubuntu 16.04 is EOL soon, so just drop it along with clang 6 and 7 which are not available on Ubuntu 18.04, the new supported LTS. Switching to Ubuntu 18.04 unfortunately triggers issue 19116, which forces us to disable 32 bits for the time being. * Attempt number 328349538459345 Co-authored-by: MoonlightSentinel <moonlightsentinel@disroot.org> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Mathias LANG <geod24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been done in dlang/dmd#12269 already.