Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Merge stable #3398

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Merge stable #3398

merged 3 commits into from
Mar 15, 2021

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Mar 15, 2021

Fix Github Actions.

MoonlightSentinel and others added 3 commits March 6, 2021 08:31
...checkaction=context. These deprecations are issued when
`real.sizeof = double.sizeof`.

This is a workaround for https://issues.dlang.org/show_bug.cgi?id=20759.
* Github CI: Use dmd-latest

Not providing an argument defaults to dmd-latest,
which is what we want.

* Github CI: Remove no-longer needed workaround

* Github CI: Use correct comment syntax on Windows

* Github CI: Use Windows paths on Windows

* Github CI: Drop Ubuntu 16.04 and clang < 8, disable 32 bits

We're having issues due to yet another change by Github to their image,
and Ubuntu 16.04 is EOL soon, so just drop it along with clang 6 and 7
which are not available on Ubuntu 18.04, the new supported LTS.
Switching to Ubuntu 18.04 unfortunately triggers issue 19116,
which forces us to disable 32 bits for the time being.

* Attempt number 328349538459345
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
19116 normal dmd compiles binary but segfaults immediately when run on Ubuntu / Debian 32Bit architectures
21666 normal wrong printf format specifier for real with -checkaction=context on Win64

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3398"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Mar 15, 2021
@Geod24 Geod24 mentioned this pull request Mar 15, 2021
@PetarKirov
Copy link
Member

@Geod24 Feel free to force-merge yourself.

@dlang-bot dlang-bot merged commit 3a32cc0 into master Mar 15, 2021
@Geod24
Copy link
Member Author

Geod24 commented Mar 15, 2021

I just needed to change the branch rules, no need for such violence.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants