Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 22766 - copyEmplace does not work with copy constructor and @disable this() #3799

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

RazvanN7
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22766 enhancement copyEmplace does not work with copy constructor and @disable this()

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3799"

@dlang-bot dlang-bot added the Enhancement New functionality label Apr 12, 2022
@RazvanN7 RazvanN7 requested a review from kinke April 12, 2022 12:49
Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a D Style thing.

src/core/lifetime.d Outdated Show resolved Hide resolved
Co-authored-by: Dennis <dkorpel@users.noreply.github.com>
@dlang-bot dlang-bot merged commit 9ba9a6a into dlang:master Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants