Don't re-initialize D class instances in destroy!false()

[kinke]

When it's explicitly not requested.

[dlang-bot]

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23129	normal	object.destroy doesn't consider initialize=false on D classes

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3821"

[ljmf00]

Please file an issue as this affects the end user.

[kinke]

I consider this a tiny performance improvement, not worth a changelog entry IMO.

[ljmf00]

I consider this a tiny performance improvement, not worth a changelog entry IMO.

I meant an issue, not a changelog entry. From the user perspective, doing destroy!false(c) on a class and not working, assumes a bug on destroy, as it is a documented and well-defined expected behaviour.

[dkorpel]

@kinke I've filed an issue for you: https://issues.dlang.org/show_bug.cgi?id=23129

I don't have rights to commit to your branch, can you add "Fix issue 23129" to the commit message?

[kinke]

Cheers Dennis, done (& rebased).

Issue filed