This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
require nothrow for callWithStackShell callback #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I've compiled essentially the same patch and run the unit tests with ldc for linux/arm, so lgtm. |
|
Tested with GDC, passes. |
redstar
added a commit
to ldc-developers/druntime
that referenced
this pull request
Sep 28, 2014
The mangled name changes again with druntime pull request dlang#966 (which is required for ARM).
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Sep 28, 2014
require nothrow for callWithStackShell callback
kinke
added a commit
to ldc-developers/druntime
that referenced
this pull request
Aug 14, 2016
We initialize the instance in DtoNewClass(), so elide pre-initializing it in _d_newclass().
kinke
added a commit
to ldc-developers/druntime
that referenced
this pull request
Aug 14, 2016
We initialize the instance in DtoNewClass(), so elide pre-initializing it in _d_newclass().
kinke
added a commit
to ldc-developers/druntime
that referenced
this pull request
Aug 14, 2016
We initialize the instance in DtoNewClass(), so elide pre-initializing it in _d_newclass().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.