Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecate warnings #2617

Closed
ryuukk opened this issue Mar 7, 2023 · 2 comments
Closed

Get rid of deprecate warnings #2617

ryuukk opened this issue Mar 7, 2023 · 2 comments

Comments

@ryuukk
Copy link
Contributor

ryuukk commented Mar 7, 2023

Deprecate warnings should fixed before they become errors:

source\dub\dependency.d(917,18): Deprecation: scope variable `this` assigned to non-scope parameter `oth` calling `opEquals`
source\dub\dependency.d(920,30): Deprecation: scope variable `this` assigned to non-scope parameter `a` calling `doCmp`
source\dub\dependency.d(921,27): Deprecation: scope variable `this` assigned to non-scope parameter `b` calling `doCmp`
source\dub\dependency.d(939,26): Deprecation: scope variable `this` assigned to non-scope parameter `oth` calling `opEquals`
source\dub\internal\configy\Exceptions.d(130,34): Deprecation: reference to local variable `buffer` assigned to non-scope anonymous parameter
source\dub\internal\configy\Exceptions.d(134,34): Deprecation: reference to local variable `buffer` assigned to non-scope anonymous parameter
source\dub\internal\configy\Exceptions.d(248,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(250,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(283,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(286,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(323,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(325,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(332,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
source\dub\internal\configy\Exceptions.d(335,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\write.d(537,34):        which calls `std.format.spec.FormatSpec!char.FormatSpec.writeUpToNextSpec!(void delegate(in char[]) @safe).writeUpToNextSpec`
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        which would be `@system` because of:
C:\D\dmd2\windows\bin\..\..\src\phobos\std\format\spec.d(258,33):        scope variable `this` assigned to non-scope parameter `e` calling `put`
@WebFreak001
Copy link
Member

these deprecations won't turn into warnings if -preview=in gets enabled before that, because with that enabled, all except one deprecations are gone.

Will open a PR to add -preview=in to dflags (although I'm not a big fan of the preview switch as it isn't future-proof / breaks once the feature is actually added)

WebFreak001 added a commit to WebFreak001/dub that referenced this issue Mar 9, 2023
WebFreak001 added a commit to WebFreak001/dub that referenced this issue Mar 9, 2023
WebFreak001 added a commit to WebFreak001/dub that referenced this issue Mar 9, 2023
WebFreak001 added a commit to WebFreak001/dub that referenced this issue Mar 9, 2023
@Geod24
Copy link
Member

Geod24 commented Jan 17, 2024

This is now fixed for dub build. There are a few deprecations with dub test but I'll resolve those soon.

@Geod24 Geod24 closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants