Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop referring to "installation" in commands #150

Merged
merged 4 commits into from Nov 1, 2013

Conversation

Projects
None yet
3 participants
@mihails-strasuns
Copy link

commented Oct 31, 2013

Changes commands names, help output and actual code to use more neutral
get/remove and derivatives. Old command names remain undocumented and
warned about.

This is somewhat temporary solution to avoid common user confusion in the short term.
Having a quick run through the source during renaming I really got an impression that dub
should benefit a lot from creating a clear definitions / vocabulary for used entities and
providing more hirearchical commands endorsing those. This is something I am not going to
speculate above until registry enhancements though.

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Oct 31, 2013

Looks like you have worked on an out-of-date branch ("We can’t automatically merge this pull request.")?

Just "list" makes sense, probably better than "list-available" or something. I'm still not completely sold on "get" vs. something else like "fetch" (maybe that is caused by the association of "get" with a simple getter that doesn't do any work). But since that's just a matter of changing a handful of places we can change that over the next days if something is deemed better.

--system Install system wide instead of user local
--local Install as in a sub folder of the current directory
--system Put package into system wide dub cache instead of user local one
--local Put packahe to a sub folder of the current directory

This comment has been minimized.

Copy link
@jacob-carlborg

jacob-carlborg Oct 31, 2013

Contributor

Spell error. "packahe" -> "package".

@jacob-carlborg

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2013

I like "fetch" as well.

@mihails-strasuns

This comment has been minimized.

Copy link
Author

commented Nov 1, 2013

Ok, rebased + command-line uses fetch now.

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Nov 1, 2013

Thanks!

s-ludwig added a commit that referenced this pull request Nov 1, 2013

Merge pull request #150 from Dicebot/install_rename
Stop referring to "installation" in commands

@s-ludwig s-ludwig merged commit 75aa3e4 into dlang:master Nov 1, 2013

@jacob-carlborg

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2013

It's still using "get" internally. I guess that's ok.

s-ludwig added a commit that referenced this pull request Nov 1, 2013

@s-ludwig

This comment has been minimized.

Copy link
Member

commented Nov 1, 2013

Thanks, fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.