Make the testsuite re-runnable on OSX #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @Geod24! |
thewilsonator
approved these changes
May 18, 2020
Closed
…oducible It's a terrible solution, but it works for the time being.
After the initial run, one couldn't run this test again as the expected message 'building configuration' would not be printed anymore.
It's the little things in life, like being able to re-run your test-suite on your own machine, that makes the greatest joy.
This currently fails on Mac because the '.so' is hardcoded. It should eventually be fixed, but for the time being, my objective is to get things to pass on my machine.
Who would have known that the following would pass on Linux but not Mac OSX: --- touch file rm -f file/nonono --- Well surely not me. And indeed "b" is a file, not a directory, so this rm didn't make sense. Just use dub clean. Like the rest of us.
On Mac OSX, this script fails because of the behavior of pipefail. A simple ' || true' solves the problem, while 'grep' still ensures it behaves as expected.
This test is only supposed to be run, not unittested. It can create a problem when one wants to re-run the test suite, as if the unittest have been built, there's an extra file in the bin directory, which in turns makes the test fail.
Geod24
force-pushed
the
cross-platform-testsuite
branch
from
d323398 to
0744aac
Compare
|
Fixed the micro failure (missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
There's still a lot to do, like cleaning up the mess the testsuite create, or not messing up with the users packages, but one step at a time.
Part of #1829