Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1917 - Add dub dustmite --no-redirect #1967

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@wilzbach
Copy link
Member

Looks like you need to make the file executable:

test/run-unittest.sh: line 47: /home/travis/build/dlang/dub/test/dustmite-no-redirect.sh: Permission denied

@MoonlightSentinel MoonlightSentinel force-pushed the no-redirect branch 5 times, most recently from d1cc040 to 9050318 Compare June 15, 2020 23:46
@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Jun 16, 2020

I have no idea why the script fails on buildkite...
The test script tried to execute dustmite's temporary directories.

@MoonlightSentinel MoonlightSentinel force-pushed the no-redirect branch 2 times, most recently from ad404db to eb73e00 Compare June 25, 2020 14:36
@MoonlightSentinel
Copy link
Contributor Author

Ping

@dlang-bot dlang-bot merged commit 3800f7f into dlang:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants