Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2046 - Dependencies specified with a path ignore optional settings #2103

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

shoo
Copy link
Contributor

@shoo shoo commented Feb 1, 2021

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @shoo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@dlang-bot dlang-bot merged commit add301a into dlang:master Mar 1, 2021
@shoo shoo deleted the fix_issue2046 branch March 4, 2021 15:54
@CyberShadow
Copy link
Member

@shoo How do I get the old behavior?

I would like to use a package with a path if it exists at that path, regardless if it's specified in some dub.selections.json file.

That way we can use autoconf-like autodetection to build features which use only those dependencies that are installed on the local system. But after this change, I don't see how this is possible. With optional=true default=true, Dub doesn't use the package even when it's present; if I also add it to dub.selections.json, then it tries to use it even if it's absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants