Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed generation of Solution Platform for x64 #455

Merged
merged 8 commits into from
Dec 10, 2014

Conversation

londey
Copy link
Contributor

@londey londey commented Nov 13, 2014

No description provided.

@MartinNowak
Copy link
Member

Your indentation is off (dub uses tabs), consider using EditorConfig.

@@ -96,12 +105,12 @@ class VisualDGenerator : ProjectGenerator {
// Global section contains configurations
ret.put("Global\n");
ret.put("\tGlobalSection(SolutionConfigurationPlatforms) = preSolution\n");
ret.formattedWrite("\t\t%s|Win32 = %s|Win32\n", settings.buildType, settings.buildType);
ret.formattedWrite("\t\t%s|%s = %s|%s\n", settings.buildType, settings.platform.architecture[0].vsCpuArchitecture, settings.buildType, settings.platform.architecture[0].vsCpuArchitecture);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break the line :).

- Moved to end of module and made private similar to existing utility
functions
- Cleaned up spaces instead of tabs
@MartinNowak
Copy link
Member

Nice :), please make sure to ping when pushing new commits, as one doesn't get notified otherwise.

MartinNowak added a commit that referenced this pull request Dec 10, 2014
Fixed generation of Solution Platform for x64
@MartinNowak MartinNowak merged commit b69cb9c into dlang:master Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants