modify access rights for sc.ini to allow all users to read the file #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't see you did this. I have an alternative version: #166 Not sure which is better. |
|
Both PRs seem to set a specific set of permissions. Ideally we'd want to delete all file-specific permissions, and make the file inherit the directory's permissions - meaning that if DMD has been installed to a user-writable directory, the .ini file should be writable too, but not if it was installed e.g. under Program Files. |
|
It's a bit annoying to have the dependency on a non-standard NSIS plugin, so I'll close this in favor of PR #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission is lost during modification by _ReplaceInFile.
You'll need to install the AccessControl-plugin for NSIS to build this.