Windows: add detection of VS 2017 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be more conservative and prefer one of the older versions if multiple VS are installed? |
|
Prefer the latest. |
MartinNowak
reviewed
Apr 22, 2017
| ReadRegStr $0 HKLM "SOFTWARE\Microsoft\VisualStudio\SxS\VS7" "15.0" | ||
| StrCpy $1 "VC2017" | ||
| IfErrors not_vc2017 | ||
| ${LineRead} "$0\VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt" "1" $2 |
There was a problem hiding this comment.
For reference NSIS 2.46 Users Manual#LineRead.
kdmult
reviewed
May 4, 2017
| @@ -351,6 +352,15 @@ SectionGroupEnd | |||
| Function DetectVSAndSDK | |||
| ClearErrors | |||
|
|
|||
| ReadRegStr $0 HKLM "SOFTWARE\Microsoft\VisualStudio\SxS\VS7" "15.0" | |||
There was a problem hiding this comment.
I have installed VS 2017 Pro and there is no key HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7.
But there is HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7.
There was a problem hiding this comment.
See answer below #227 (comment).
The installer is a 32-bit process so the key is translated to the Wow6432Node by a 64-bit OS. |
|
This should have been targeted at stable. I cherry-picked it, s.t. it's part of the 2.074.2 release ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs dlang/dmd#6716
See https://issues.dlang.org/show_bug.cgi?id=17280 and https://issues.dlang.org/show_bug.cgi?id=17320