Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19434 - "Invalid signature" when using install.sh with no ~/.gnupg #352

Merged
merged 3 commits into from Nov 27, 2018

Conversation

CyberShadow
Copy link
Member

No description provided.

Fixes creating a randomly-named file in the *current* directory.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @CyberShadow!

Bugzilla references

Auto-close Bugzilla Severity Description
19434 normal "Invalid signature" when using install.sh with no ~/.gnupg

- Avoid polluting users' home directories when running test suite
- Ensure we test with a clean slate
On some (older?) versions, --verify will fail if GNUPGHOME (~/.gnupg)
does not exist, even with --no-default-keyring, as that's where it
creates its temporary files.

Fixes issue 19434.
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how a93c799 improves things, otherwise LGTM.

@wilzbach wilzbach merged commit ce22504 into dlang:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants