Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21439: install.sh is disabled for LDC on FreeBSD #477

Merged
merged 1 commit into from Dec 1, 2020

Conversation

jacob-carlborg
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @jacob-carlborg! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21439 major install.sh is disabled for LDC on FreeBSD

@dlang-bot dlang-bot merged commit d97cec8 into dlang:master Dec 1, 2020
@jacob-carlborg jacob-carlborg deleted the install.sh-freebsd-21439 branch December 1, 2020 08:53
@jacob-carlborg
Copy link
Contributor Author

@MartinNowak can you please deploy this?

@wilzbach
Copy link
Member

wilzbach commented Dec 5, 2020

Sorry for the slow reaction time to this, but I don't think this is a good idea. If FreeBSD is supported, then it should be added explicitly and with a good error message. Without this explicit check, people using it on other systems will get all kind of hard to understand errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants