Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer 64 bit over 32 bit DMD on Windows 64 bit. #555

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

veelo
Copy link
Contributor

@veelo veelo commented Jan 13, 2023

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 13, 2023

Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23623 minor On 64 bit Windows the path should point to 64 bit dmd.

@veelo
Copy link
Contributor Author

veelo commented Jan 13, 2023

I haven't built the installer at home, I am hoping CI will give me one to confirm that this actually works...

@thewilsonator
Copy link
Collaborator

Please title the commit message to say "Fix issue 223623: ..."

@ibuclaw ibuclaw merged commit 2f9caa9 into dlang:stable Jan 15, 2023
@veelo
Copy link
Contributor Author

veelo commented Jan 16, 2023

Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants