This is 3% faster because of better use of speculative hardware

dlang · Aug 12, 2016 · 66ba7b8 · 66ba7b8
1 parent 30cb519
commit 66ba7b8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/std/algorithm/sorting.d b/std/algorithm/sorting.d
@@ -1340,12 +1340,16 @@ private void quickSortImpl(alias less, Range)(Range r, size_t depth)
         r.swapAt(pivotIdx, r.length - 1);
         size_t lessI = size_t.max, greaterI = r.length - 1;
 
-        while (true)
+        outer: for (;;)
         {
             alias pred = binaryFun!less;
             while (pred(r[++lessI], pivot)) {}
             assert(lessI <= greaterI, "sort: invalid comparison function.");
-            while (greaterI > lessI && pred(pivot, r[--greaterI])) {}
+            for (;;)
+            {
+                if (greaterI == lessI) break outer;
+                if (!pred(pivot, r[--greaterI])) break;
+            }
             assert(lessI <= greaterI, "sort: invalid comparison function.");
             if (lessI == greaterI) break;
             r.swapAt(lessI, greaterI);