Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto interface in phobos #10269

Open
dlangBugzillaToGithub opened this issue Nov 1, 2017 · 3 comments
Open

Crypto interface in phobos #10269

dlangBugzillaToGithub opened this issue Nov 1, 2017 · 3 comments

Comments

@dlangBugzillaToGithub
Copy link

andre reported this on 2017-11-01T15:23:06Z

Transfered from https://issues.dlang.org/show_bug.cgi?id=17958

CC List

  • greensunny12

Description

In discussion https://forum.dlang.org/thread/osnema$d5s$1@digitalmars.com it became clear, including crypto logic into phobos might be a pandora box and should be avoided.
An alternative is to provide a crypto interface within phobos with implementations for SChannel (windows api), mbedtls, openssl, ...

As a starting point, I am interested in RSA Digital Signature Validation but The crypto interface should be open for any algorithm.
@dlangBugzillaToGithub
Copy link
Author

andre commented on 2017-11-01T15:23:49Z

*** Issue 16510 has been marked as a duplicate of this issue. ***

@dlangBugzillaToGithub
Copy link
Author

greensunny12 commented on 2018-02-09T11:56:50Z

Hmm, not sure if this wouldn't be a huge effort for Phobos + given that crypto needs to be able to be patched within hours, I'm inclined to make this a WONTFIX too.

The best library solution I know is this https://github.com/LightBender/SecureD

@dlangBugzillaToGithub
Copy link
Author

andre commented on 2018-02-14T21:04:33Z

(In reply to Seb from comment #2)
> Hmm, not sure if this wouldn't be a huge effort for Phobos + given that
> crypto needs to be able to be patched within hours, I'm inclined to make
> this a WONTFIX too.
> 
> The best library solution I know is this
> https://github.com/LightBender/SecureD

If in Phobos crypto functionality isn't directly implemented but a nice wrapper is available around operation system crypto libraries (on windows SChannel) / OpenSSL /... then neither Phobos needs to be patched nor the application developer needs to ship a new version of his application.

The crypto fix will be provided by the operation system (windows update in case of windows...)
(Delphi is using this approach)

What I suggest is a crypto interface in Phobos with implementations for SChannel / OpenSSL / ...

@LightBender LightBender removed the P4 label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants