Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now that OMF support has been dropped, the standard library should be called phobos32 not phobos32mscoff #10554

Open
dlangBugzillaToGithub opened this issue Jun 1, 2024 · 2 comments
Labels
Arch:x86 Issues specific to x86 OS:Windows Issues Specific to Windows Review:Trivial typos, formatting, comments

Comments

@dlangBugzillaToGithub
Copy link

iamthewilsonator (@thewilsonator) reported this on 2024-06-01T05:15:33Z

Transfered from https://issues.dlang.org/show_bug.cgi?id=24576

CC List

  • kinke

Description

see title, https://github.com/dlang/dmd/pull/16548#discussion_r1623148837
@dlangBugzillaToGithub
Copy link
Author

kinke commented on 2024-06-01T16:38:55Z

I'd argue it's time to drop any ugly suffix and just go with `phobos2.lib` whn revising this, as on Posix. Note that the 32-bit lib is currently in a `lib32mscoff` directory too, in the install package. So changing this entails the Phobos Makefile, the compiler sc.ini + hardcoded stuff, and the installer repo; possibly more.

@dlangBugzillaToGithub
Copy link
Author

iamthewilsonator commented on 2024-06-01T22:49:01Z

the different directory and the smattering of Makefiles changes, compiler sc.ini, etc. was part of the reason that this was such a PITA to try to change it. We should have it configured in one place  ideally.

@LightBender LightBender removed the P1 label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch:x86 Issues specific to x86 OS:Windows Issues Specific to Windows Review:Trivial typos, formatting, comments
Projects
None yet
Development

No branches or pull requests

2 participants