byCodeUnit should compare with strings

[dlangBugzillaToGithub]

schveiguy (@schveiguy) reported this on 2018-09-25T15:55:38Z

Transfered from https://issues.dlang.org/show_bug.cgi?id=19264

CC List

• dcuan17
• edi33416

Description

In order for byCodeUnit to be a near drop-in replacement for strings, it would be nice to have them compare directly with strings.

This means, I would expect this to work:

assert("hello".byCodeUnit == "hello");

This probably means adding opEquals overloads for everything, which also means adding toHash overloads.

I'd say just comparing to the base type should be sufficient, no need for transcoding for comparison.

[dlangBugzillaToGithub]

schveiguy (@schveiguy) commented on 2018-09-25T15:58:05Z

It shouldn't matter the constancy of the original.

This should also work:

assert("hello".byCodeUnit == "hello".dup.byCodeUnit);