Fix issue 8061. #1019
Merged
Fix issue 8061. #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot assume that RoR.save will also .save the state of its subranges; so the only way we can correctly export a .save method in the joined range is if we also .save its subranges as we traverse over them.
| // We cannot export .save method unless we ensure subranges are not | ||
| // consumed when a .save'd copy of ourselves is iterated over. So | ||
| // we need to .save each subrange we traverse. | ||
| static if (isForwardRange!(ElementType!RoR)) |
There was a problem hiding this comment.
I'd say same as the save condition:
static if (isForwardRange!RoR && isForwardRange!(ElementType!RoR))No point in saving if joiner isn't going to propose forward range iteration anyways.
|
Fixed as discussed in the message boards, the bug repo, and the previous pull (#987). So LGTM on this one. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot assume that RoR.save will also .save the state of its
subranges; so the only way we can correctly export a .save method in the
joined range is if we also .save its subranges as we traverse over them.