-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 10386: Make std.math.isIdentical work in CTFE with coverage tests #10576
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: runiixx <murgua03@gmail.com>
|
Thanks for your pull request and interest in making D better, @runiixx! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
|
We are no longer using or linking to Bugzilla for Phobos. I have updated the PR title, but can you please update the commit message to reference the corresponding GH Issue here: #10386 |
Signed-off-by: runiixx <murgua03@gmail.com>
Signed-off-by: runiixx <murgua03@gmail.com>
I took the modifications @n8sh made in math.d and moved in traits.d since math.d doesn't exist anymore and the math library is now composed of multiple files, and then added more tests because the piece of code that is interpreted in CTFE wasn't covered.
Credit to @n8sh for the code in isIdentical.