Remove some undocumented, deprecated functions which are slated for removal. #1176
Conversation
| @@ -1149,74 +1106,6 @@ unittest | |||
| } | |||
|
|
|||
|
|
|||
| //Explicitly undocumented. Do not use. To be removed in March 2013. | |||
| deprecated S capwords(S)(S s) if (isSomeString!S) | |||
There was a problem hiding this comment.
How come this one is removed? Was it just not used by anyone? Asking because there's no alternative mentioned.
(I don't think I've ever used it though so I won't miss it).
There was a problem hiding this comment.
IIRC, when we fixed a lot of the names in std.string, we decided that the function was overly specific and didn't provide enough value, but regardless of the reasoning, it's been deprecated for some time and outright undocumented for several months of that. So, if we wanted it, we'd pretty much need to reintroduce it anyway (and with a properly capitalized name).
|
LGTM. |
|
Fails Win32. |
…emoval. These have been deprecated for a while, but there was some balking (primarily from Andrei IIRC) at actually removing them when they were slated for removal, so they were instead made undocumented and slated for removal after yet another 6 months or so. So, now that that time has passed, here's another attempt to actually remove them.
|
Updated. Hopefully, it'll pass this time. |
| deprecated("Please use std.ascii.digits instead.") immutable digits = "0123456789"; | ||
| deprecated("Please use std.ascii.octalDigits instead.") immutable char[8] octdigits = "01234567"; | ||
| deprecated("Please use std.ascii.lowercase instead.") immutable char[26] lowercase = "abcdefghijklmnopqrstuvwxyz"; | ||
| deprecated("Please use std.ascii.letters instead.") immutable char[52] letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; |
There was a problem hiding this comment.
Interestingly this one was just plain wrong as it contains 26 letters not 52.
There was a problem hiding this comment.
Yeah. But what was wrong was the initializer itself, it should be like the current one in std.ascii:
immutable letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" ~
"abcdefghijklmnopqrstuvwxyz";I'd kind of wish the compiler complained about the old initializer, especially since it's immutable.
|
Why does Github say |
|
Edit: Could it be that the tester decided to test all pulls from start again due to a new merge to master? Because in that case it should really reset all statuses so they write "pending" or something, instead of leaving it to this old status. |
Remove some undocumented, deprecated functions which are slated for removal.
These have been deprecated for a while, but there was some balking
(primarily from Andrei IIRC) at actually removing them when they were
slated for removal, so they were instead made undocumented and slated
for removal after yet another 6 months or so. So, now that that time has
passed, here's another attempt to actually remove them.