Improve std.conv.to (3) #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
Also, you've messed with std.conv enough at this point that you should probably put your name in the list of authors. |
…straint of S -> constraint of T) for code readability.
…ible The two templates has same purpose, but bit different behaviors. implicitlyConverts(S, T) has following semantics: is(S : T) and allow initializer conversion (T t = s; -> T t = T(s);) Including initializer conversion is inconvenience for my to!() improvement in after commits, so replace it.
1. Remove conversion feature using member template function to!T() of user type. 2-1. Support conversion feature using opCast!T() with aggregate types. 2-2. Support conversion feature using constructor like T(s) with struct types.
|
Rebase and add author. |
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
…exe-target Fix rdmd --makedep(end|file) (issues 12351 and 12354)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #119.
The readability of std.conv module document is not good.
I collected toImpl functions by its 'conversion kind'.
Generated html is here: (Sorry, can't preview directly.)
https://gist.github.com/2bb2b072945903ea9e74