Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround issue 9634 #1290

Merged
merged 1 commit into from
Jun 7, 2013
Merged

Workaround issue 9634 #1290

merged 1 commit into from
Jun 7, 2013

Conversation

DmitryOlshansky
Copy link
Member

Anything for the sake of ctRegex! :)

Seriously I'd rather see that bug fixed in DMD but this could serve as interim solution.

@@ -1299,7 +1299,12 @@ struct Parser(R, bool CTFE = false)
}
put(Bytecode(greedy ? IR.InfiniteStart : IR.InfiniteQStart, len));
enforce(ir.length + len < maxCompiledLength, "maximum compiled pattern length is exceeded");
ir ~= ir[offset .. offset+len];
if(__ctfe){ //workaround @@@BUG@@@ 9634
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paren and brace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed brace.
I'll spare the paren change for some distant future since this module doesn't use "space before paren" style anywhere.

@MartinNowak
Copy link
Member

LGTM.

It would be nice if we had a roundtrip from a fix in Bugzilla to posting in merged workaround pull requests.

@DmitryOlshansky
Copy link
Member Author

Ping @andralex @dawgfoto

@MartinNowak
Copy link
Member

Sorry, I don't have commit rights for phobos.

@andralex
Copy link
Member

andralex commented Jun 7, 2013

regex.d is quite foreign in style compared to the rest of phobos (no spacing around operators and a few smaller things), sigh.

andralex added a commit that referenced this pull request Jun 7, 2013
@andralex andralex merged commit db7e325 into dlang:master Jun 7, 2013
@andralex
Copy link
Member

andralex commented Jun 7, 2013

@dawgfoto added you to team phobos

@MartinNowak
Copy link
Member

regex.d is quite foreign in style compared to the rest of phobos (no spacing around operators and a few smaller things), sigh.

Better D lexer/parsing tools to the rescue.

@DmitryOlshansky
Copy link
Member Author

regex.d is quite foreign in style compared to the rest of phobos (no spacing around operators and a few smaller things), sigh.

cough std.parallelism cough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants