-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround issue 9634 #1290
Workaround issue 9634 #1290
Conversation
| @@ -1299,7 +1299,12 @@ struct Parser(R, bool CTFE = false) | |||
| } | |||
| put(Bytecode(greedy ? IR.InfiniteStart : IR.InfiniteQStart, len)); | |||
| enforce(ir.length + len < maxCompiledLength, "maximum compiled pattern length is exceeded"); | |||
| ir ~= ir[offset .. offset+len]; | |||
| if(__ctfe){ //workaround @@@BUG@@@ 9634 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paren and brace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed brace.
I'll spare the paren change for some distant future since this module doesn't use "space before paren" style anywhere.
|
LGTM. It would be nice if we had a roundtrip from a fix in Bugzilla to posting in merged workaround pull requests. |
|
Ping @andralex @dawgfoto |
|
Sorry, I don't have commit rights for phobos. |
|
regex.d is quite foreign in style compared to the rest of phobos (no spacing around operators and a few smaller things), sigh. |
|
@dawgfoto added you to team phobos |
Better D lexer/parsing tools to the rescue. |
cough std.parallelism cough |
Anything for the sake of ctRegex! :)
Seriously I'd rather see that bug fixed in DMD but this could serve as interim solution.