Issue 6194 - [GSoC] Destructor gets called on object before it is copied when calling writeln() #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andralex
added a commit
that referenced
this pull request
Jul 20, 2011
Issue 6194 - [GSoC] Destructor gets called on object before it is copied when calling writeln()
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
remove redundant disqus links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that, when taking the addresses of its arguments, formattedWrite would instead take the addresses of copies created by the foreach() loop. The copies would go out of scope when the loop was exited and thus the destructors got called. I fixed the line that takes the address to index the argument tuple rather than use the copy.