Support degenerate bitfields with fields of length 32 and 64 #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| maskAllElse = ((1uL << len) - 1u) << offset, | ||
| signBitCheck = 1uL << (len - 1), | ||
| extendSign = ~((cast(MasksType)1u << len) - 1); | ||
| enum ulong |
There was a problem hiding this comment.
Why remove the MasksType ?
There was a problem hiding this comment.
MasksType served no purpose, the true "mask type" gets determined by myToString function depending on the value of the mask.
Removing MasksType and using ulong for those masks removed unnecessary complexity.
|
Well, LGTM. Anybody see any outstanding issues? |
dnadlinger
added a commit
that referenced
this pull request
Oct 5, 2013
Support degenerate bitfields with fields of length 32 and 64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes http://d.puremagic.com/issues/show_bug.cgi?id=11160 / http://d.puremagic.com/issues/show_bug.cgi?id=8474
Adds tests for:
http://d.puremagic.com/issues/show_bug.cgi?id=6686
http://d.puremagic.com/issues/show_bug.cgi?id=5942
Which seem to have been fixed over time.