std.array.replaceFirst() bug and doc fixes #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing changed. This behavior is reasonable and explicitly tested for in the unit tests, but previously, one could think that they always returned a copy from the docs.
The unittest block seemed to be a direct copy of the replace() one, now it actually tests replaceFirst().
|
Oh, this was reported to Bugzilla in the meantime as well: http://d.puremagic.com/issues/show_bug.cgi?id=6428 |
andralex
added a commit
that referenced
this pull request
Aug 3, 2011
std.array.replaceFirst() bug and doc fixes
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
…ango rdmd: Remove tango warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
replaceFirstwhich was recently mentioned on the NG, and went undetected because theunittestblock didn't actually test the right function.Additionally, it clarifies the documentation for
replaceandreplaceFirstwith regard to array copying.