New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve std.conv #181
Improve std.conv #181
Conversation
On a related note, since you've been doing a fair bit of work on std.conv, you might want to consider implementing issue 6377. I tried to, but ran into errors regarding forward declarations and the like and gave up for the time being. But since you're obviously familiar with the code, you'd probably have a better shot at getting it to work. |
I found a bit problem while using parse!Char(String) function other place. |
Reply to jmdavis: |
|
||
while (exp > 0) | ||
for (int j = 0; j < errors.length; j++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loop should probably be
foreach(j, s; errors)
The same goes for the other loops just like it.
Integrate similar tests by using |
I have tried to implement it, see #185. |
Let's wait for Kenji's additions before reviewing this again. |
This request does not introduce new features; does only fixing bugs, cleaning up tests, and remove unused codes.
I have already fixed the matter Jonathan's pointed out two days before. Thanks. |
We have to limit the octal instantiation by its template constraint, not static assert in template body.
…es overflow error
parse!T(str) now supports any string types. So pre-encoding to UTF8 is not necessary.
Apply @jmdavis's fixes, and rebase commits onto git master. |
Merging in. |
tolf - rewritten in D
Cleanup code:
They have been no longer used - parseIntegral, parseFloating, toIfloat, toIdouble, toIreal, toCfloat, toCdouble, toCreal, getComplexStrings
Some unittests are redundant, so remove them.
Bug fixes: