[ARM] Implement parse!real for systems with 64bit reals #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some unittest fixes
|
Ping @donc and @ibuclaw our phobos math experts ;-) I know this solution is not exactly pretty but we need some kind of solution for ARM and as this is only a internal change it could be replaced with a better, more generic, solution at any time. BTW: The whitespace-ignoring diff is easier to read: https://github.com/D-Programming-Language/phobos/pull/1862/files?w=0 |
|
ping |
| // left justify mantissa | ||
| while (msdec >= 0) | ||
| { msdec <<= 1; | ||
| e2--; |
There was a problem hiding this comment.
Format nit pick (curly brace and statement on separate lines). Other than that, lgtm.
|
Update: Made formatting in |
|
Auto-merge toggled on |
|
Pull updated, auto_merge toggled off |
ibuclaw
added a commit
that referenced
this pull request
Feb 1, 2014
[ARM] Implement parse!real for systems with 64bit reals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement parse!real for systems where real==double.
This solution is probably not pretty, especially as it does not help on systems with 128bit reals or other sizes. However, it works fine and makes parse!real useable on ARM.
Note: This is part of a set of changes which are required to get test suite & unit tests passing on ARM GDC. All necessary changes for GDC are here for reference:
https://github.com/jpf91/GDC/commits/arm-old
Once these pull requests are merged upstream I'll merge them into GDC as well.