CTFE Dot Product #200
Merged
CTFE Dot Product #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to work around issue 6517, which was the only thing keeping the old dotProduct function from working at compile time.
|
|
||
| // Test in CTFE | ||
| enum ctfeDot = dotProduct(x, y); | ||
| static assert(ctfeDot == 2280); |
There was a problem hiding this comment.
Is there any reason why you don't simply write
static assert (dotProduct(x, y) == 2280);
?
There was a problem hiding this comment.
I guess that was silly. It's not really worth fixing now that the pull request is merged, though.
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
ddemangle, flush output for each new demangled line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 6514: CTFE dot product. This is a trivial change to the syntax to work around issue 6517, which was the only thing keeping the old dotProduct function from working at compile time.
I'd recommend accepting this pull request even if Bug 6517 (http://d.puremagic.com/issues/show_bug.cgi?id=6517) might get fixed soon, since it also improves the unit tests for dotProduct, including testing for CTFE. Also, the workaround for 6517 is a trivial syntactic change that doesn't add any maintenance burden or code complexity.