Issue 7246 - Provide a simpler example for std.algorithm.remove.

[ghost]

https://issues.dlang.org/show_bug.cgi?id=7246

[ghost]

Note that I've had to re-initialize the array since remove has side-effects.

[monarchdodra]

Perhaps that comment should be part of the documentation? I'm thinking:

    static immutable base = [1, 2, 3, 2, 4, 2, 5, 2];

    int[] arr = base[].dup;

    // using a string-based predicate
    assert(remove!("a == 2")(arr) == [ 1, 3, 4, 5 ]);

    //The original array contents have been modified,
    //so we need to reset it to its original state.
    //The length is unmodified though.
    arr[] = base[];

    // using a lambda predicate
    assert(remove!(a => a == 2)(arr) == [ 1, 3, 4, 5 ]);

As you wish. It looks fine as is too.

[ghost]

A little overkill but maybe we should document it. I got caught off-guard by it as well.

I'll make an amend.

[ghost]

Updated. Auto-merge only please since the tests must pass first. :>

[monarchdodra]

Auto-merge toggled on

[CyberShadow]

This example is simpler?

[dnadlinger]

@CyberShadow: That's the original bug title. I don't think adding the extra explanations is a bad idea, because people might not be familiar with the "slice off end"-style semantics.

[CyberShadow]

OK, my nit is that this replaces a short two-line example with one that's a bit harder to follow, with the extra variable and assignments.