Issue 13013 - Converted real to double in std.json.JSONValue #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ struct JSONValue | |||
| string str; | |||
| long integer; | |||
| ulong uinteger; | |||
| real floating; | |||
| double floating; | |||
ABI compatibility is not a concern for phobos. |
|
ABI compatibility can't be a concern at the current point at all. We don't even have a well-defined ABI to start with. |
|
Addressed the inline comment. The ABI mention was mostly to continue that train of thought from the Bug Report page. As best as I can tell, this PR is now ready. |
|
Looks good to me. |
|
Auto-merge toggled on |
dnadlinger
added a commit
that referenced
this pull request
Jul 3, 2014
Issue 13013 - Converted real to double in std.json.JSONValue
|
Okay, thanks. Should be good to go – we'll see if the type changes lead to a compatibility problem in an unexpected way during beta, I guess. |
9rnsr
pushed a commit
to 9rnsr/phobos
that referenced
this pull request
Jul 7, 2014
Issue 13013 - Converted real to double in std.json.JSONValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13013
=> Changed real to double, as it is more functional and no less correct.
One concern: ABI compatibility.
Tested this on both Windows and OSX.