Pre-allocate result array in getAddress

[JakobOvrum]

Fixes issue #13159.

[quickfur]

I think we should also improve getAddressInfoImpl to reduce allocations as well. Currently it's still doing an allocation per address returned. Perhaps using std.array.appender might be appropriate here?

On a longer term basis, we might want to consider changing the implementation to a lazy one so that we only need to allocate once for storing the final result.

[JakobOvrum]

Changed getAddressInfoImpl to use Appender; would be dishonest to close the issue after changing just getAddress when it uses getAddressInfo internally.

Since getaddrinfo usually only returns a handful of addresses it would probably be more efficient in the vast majority of cases to traverse it first to measure the length, then allocate an array of that size then traverse it again to fill the array, but worst case complexity is probably more important...

On a longer term basis, we might want to consider changing the implementation to a lazy one so that we only need to allocate once for storing the final result.

Yeah, that would be best.

[DmitryOlshansky]

LGTM

[burner]

LGTM

[mihails-strasuns]

Auto-merge toggled on

[dnadlinger]

Indentation -.-