Issue 13806: BitArray should not define member function called init() #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1219,11 +1220,27 @@ public: | |||
| return hash; | |||
| } | |||
|
|
|||
| deprecated("Please use the constructor instead.") | |||
|
works4me put deprecation date in the message pliz |
|
Done |
|
@WalterBright: depre? |
quickfur
force-pushed
the
bitarray_init
branch
2 times, most recently
from
65fe5b6 to
25ac048
Compare
|
Rebased. ping @WalterBright @andralex Should we go ahead with this? |
andralex
added a commit
that referenced
this pull request
Jan 24, 2015
Issue 13806: BitArray should not define member function called init()
|
Thanks! But shouldn't you be toggling automerge instead, in case the autotester catches a unittest failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.dlang.org/show_bug.cgi?id=13806
Look at how much more readable the unittests are after the deprecation! Seriously, how did we ever put up with this for so long??
Split into 3 commits deliberately, because I know Vladimir is going to complain about sudden deprecations, so the first commit is just a comment, the second commit is to clean up some blatant style violations, and the third is the actual deprecation and unittest cleanup.