Reject instantiating RefCounted with interface types #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monarchdodra
added a commit
that referenced
this pull request
Feb 11, 2015
Reject instantiating RefCounted with interface types
|
If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue noticed in this thread.
For the purposes of forward-compatibility,
RefCountedhas rejected classes because it is intended that in the futureRefCounted!SomeClassreference-counts the actual instance and not just a class reference. Once implemented, interfaces should be handled in a similar way.It is my intention to work on class support for
RefCounted, but in case the status quo continues for a long time, we have to reject interfaces as well.