-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name of package documentation: std_xyz_package.html -> std_xyz.html #2989
Conversation
973747d to
dc1d220
Compare
|
shouldn't these two commits be in separate PRs? They don't seem to have anything to do with each other. |
|
yah sorry please refresh |
|
I was going to look into this today, but I was going to use redirects, to avoid the Now that we have But this is good too. |
|
win32.mak will need to be updated too, as well as the Phobos navigation in dlang.org of course. |
|
Don't pull; I need to fix the menu links. This is better than redirects because it offers a scalable approach to adding new packages or converting modules to packages. |
|
I don't understand. How? You list the packages explicitly, so you could create redirects in the same way. |
With this pull all you need is specify the package in one place and its files next to it. The rest is automated. |
|
Why do you think the same technique can't be applied to redirects? |
Of course it can. What I see here is this is the direct, obvious, and already implemented approach so in a way it's incumbent already. No need to argue for it. If you think redirects are any better the burden of proof is on you. No need to waste time debating this. |
|
Related: dlang/dlang.org#905 |
|
Please do not put the blame on me for this. I've already said:
I've only continued the discussion because, as I understood at the time, you said something that contradicted my understanding of the situation, so one of us was wrong or there was a miscommunication. I only wanted to find the problem to ensure we're on the same page. I was not arguing in favor of redirects, I only wanted to know why you said that your approach was technically better when I did not see how. |
Fix name of package documentation: std_xyz_package.html -> std_xyz.html
Also put in order the package and module definitions.