Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of package documentation: std_xyz_package.html -> std_xyz.html #2989

Merged
merged 2 commits into from
Feb 16, 2015

Conversation

andralex
Copy link
Member

Also put in order the package and module definitions.

@andralex andralex force-pushed the posix.mak branch 2 times, most recently from 973747d to dc1d220 Compare February 16, 2015 06:39
@WalterBright
Copy link
Member

shouldn't these two commits be in separate PRs? They don't seem to have anything to do with each other.

@andralex
Copy link
Member Author

yah sorry please refresh

@CyberShadow
Copy link
Member

I was going to look into this today, but I was going to use redirects, to avoid the std_algorithm.html / std.algorithm.package inconsistency.

Now that we have .htaccess redirects, there could me a Makefile rule that creates a .htaccess file with the necessary rewrite rules.

But this is good too.

@CyberShadow
Copy link
Member

win32.mak will need to be updated too, as well as the Phobos navigation in dlang.org of course.

@andralex
Copy link
Member Author

Don't pull; I need to fix the menu links.

This is better than redirects because it offers a scalable approach to adding new packages or converting modules to packages.

@CyberShadow
Copy link
Member

I don't understand. How? You list the packages explicitly, so you could create redirects in the same way.

@andralex
Copy link
Member Author

I don't understand. How? You list the packages explicitly, so you could create redirects in the same way.

With this pull all you need is specify the package in one place and its files next to it. The rest is automated.

@CyberShadow
Copy link
Member

Why do you think the same technique can't be applied to redirects?

@andralex
Copy link
Member Author

Why do you think the same technique can't be applied to redirects?

Of course it can. What I see here is this is the direct, obvious, and already implemented approach so in a way it's incumbent already. No need to argue for it. If you think redirects are any better the burden of proof is on you. No need to waste time debating this.

@andralex
Copy link
Member Author

Related: dlang/dlang.org#905

@CyberShadow
Copy link
Member

Please do not put the blame on me for this.

I've already said:

But this is good too.

I've only continued the discussion because, as I understood at the time, you said something that contradicted my understanding of the situation, so one of us was wrong or there was a miscommunication. I only wanted to find the problem to ensure we're on the same page.

I was not arguing in favor of redirects, I only wanted to know why you said that your approach was technically better when I did not see how.

CyberShadow added a commit that referenced this pull request Feb 16, 2015
Fix name of package documentation: std_xyz_package.html -> std_xyz.html
@CyberShadow CyberShadow merged commit 2c5294b into dlang:master Feb 16, 2015
@andralex andralex deleted the posix.mak branch February 16, 2015 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants