enhance std.string.indexOf(startIdx) with ranges #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (startIdx < s.length) | ||
| static if (isSomeString!Range || hasSlicing!Range) |
There was a problem hiding this comment.
Also needs && hasLength!Range, although it could also be amended to have a path that uses slicing to search in infinite ranges that support such.
WalterBright
force-pushed
the
indexOf-Range2
branch
from
855b3b7 to
e3f419a
Compare
|
Didn't see the updated commit; LGTM. |
|
Auto-merge toggled on |
JakobOvrum
added a commit
that referenced
this pull request
Apr 26, 2015
enhance std.string.indexOf(startIdx) with ranges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade http://dlang.org/phobos/std_string.html#.indexOf.2 to handle input ranges as well as arrays.