Posix 2.057 Makefile error breaking 64bit build #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osix 2.057 Makefile error breaking 64bit build
| @@ -287,7 +287,7 @@ install : release | |||
| sudo cp $(LIB) /usr/lib/ | |||
|
|
|||
| $(DRUNTIME) : | |||
| $(MAKE) -C $(DRUNTIME_PATH) -f posix.mak | |||
| $(MAKE) -C $(DRUNTIME_PATH) -f posix.mak -m$(MODEL) | |||
There was a problem hiding this comment.
Um.. shouldn't that be: MODEL=$(MODEL)?
There was a problem hiding this comment.
yeah.. memory failed, should have used copy paste xD commited the correct version.
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Phobos makefile (posix.mak) does not specify the architecture for building
druntime, which defaults to 32bit even on if Phobos is being compiled for
64bit, the result is a broken lib.
My fixed Makefile passes the MODEL=64 parameter down to druntime's make
process, resulting in nice and working builds on both, 32 and 64bit systems. I
will post it in just a sec.
Happy hacking on 64 bit systems :P