Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .di files #3407

Closed
wants to merge 1 commit into from
Closed

Generate .di files #3407

wants to merge 1 commit into from

Conversation

andralex
Copy link
Member

Always generate .di files (even if unused for now) so developers can discuss them a la "array.di line 23 in master".

@andralex
Copy link
Member Author

I could measure a degradation of debug build time by less than 5%.

@MartinNowak
Copy link
Member

What's the purpose of this?

@kuettler
Copy link
Contributor

I did not know you could do that, it sure is a useful feature. I like it.

@JinShil
Copy link
Contributor

JinShil commented Jun 23, 2015

so developers can discuss them a la "array.di line 23 in master".

I don't understand the motivation. Using github, you can currently refer to array.d line 23 (even at a specific commit) in a convenient link.

@quickfur
Copy link
Member

I don't understand the motivation either. Why is it necessary for developers to reference line numbers, and how does this PR help? Most of Phobos is templated, meaning the template body gets included in the .di file, so most of the changes checked into Phobos will also change the line numbers in the .di file. So generating .di files doesn't really help retain consistent line numbers either, given the rapid rate at which Phobos changes are merged.

@DmitryOlshansky
Copy link
Member

I don't understand the motivation either. Why is it necessary for developers to reference line numbers, and how does this PR help?

Same here and it's looks abandoned.
@andralex OK to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants