Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7078 BigInt.toInt returns a long #358

Merged
merged 1 commit into from
Dec 8, 2011

Conversation

donc
Copy link
Collaborator

@donc donc commented Dec 8, 2011

Just a silly typo.

@WalterBright
Copy link
Member

I don't think I'm ever going to get this beta out tonight.

WalterBright added a commit that referenced this pull request Dec 8, 2011
7078 BigInt.toInt returns a long
@WalterBright WalterBright merged commit 59adc37 into dlang:master Dec 8, 2011
@donc
Copy link
Collaborator Author

donc commented Dec 8, 2011

I don't think I'm ever going to get this beta out tonight.

Hey, I wasn't expecting this to go into the release! (Nor the previous pull request, that Andrei folded in). It's not a regression.

I hate github's pull requests. They don't distinguish 'this is ready to be pulled' from 'please pull this now!' Would be good to develop a way to flag urgent vs non-urgent pull requests.

@WalterBright
Copy link
Member

The trouble happened because I needed to push std/traits.d, and it wouldn't let
me do a push until after I'd done a pull. Doing a pull brought in the bigint
changes.

On 12/8/2011 2:19 AM, Don Clugston wrote:

I don't think I'm ever going to get this beta out tonight.
Hey, I wasn't expecting this to go into the release! (Nor the previous pull request, that Andrei folded in). It's not a regression.

I hate github's pull requests. They don't distinguish 'this is ready to be pulled' from 'please pull this now!' Would be good to develop a way to flag urgent vs non-urgent pull requests.

@dnadlinger
Copy link
Member

… which is understandable, because once the pull request has been merged via the web interface, pushing a version that doesn't have it to the public repo would be rewriting history.

marler8997 pushed a commit to marler8997/phobos that referenced this pull request Nov 10, 2019
Add information about the --shebang switch to the rdmd man page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants