Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 15215 - Erroneous error messages in to!IntegralType conversions #3728

Closed

Conversation

CyberShadow
Copy link
Member

@CyberShadow
Copy link
Member Author

By necessity, the second commit removes a template de-bloating optimization for small integers. It's probably fine.

@DmitryOlshansky
Copy link
Member

It's probably fine.

Personally I can leave with error message not specifying which exact type is converted to which, having generic message such as "string to integer" is perfectly fine.

@JackStouffer
Copy link
Member

LGTM

@quickfur
Copy link
Member

Just realized that #4008 is a total duplicate of this PR (except worse :-P). Since it's checked in now, is there anything left to do here? perhaps check in the better unittests? Or should we just close this?

@DmitryOlshansky
Copy link
Member

Ping @CyberShadow

@CyberShadow
Copy link
Member Author

Well, I don't know. How should I feel about this? I submit a PR, it sits for a few months, then another PR is submitted which addresses the same thing to a lesser degree, and that one gets merged in two days.

It wasn't my itch to scratch, so I think I'm just going to stop caring about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants