Fix DList.insertFront(range) regression - #15263. #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just use |
As createNode was taking a value by ref, Dlist.insertFront could not be called with a range with a non-ref front. Fix by taking the value as `auto ref` instead of just `ref`. Resolves #15263.
rcorre
force-pushed
the
dlist_insert_fix
branch
from
f29539a to
05fd49e
Compare
|
Doh, good point. Fixed. |
|
LGTM |
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Oct 31, 2015
Fix DList.insertFront(range) regression - #15263.
|
If this is a regression fix, shouldn't this have gone into stable? |
Crap, that's right. Anyhow CC @MartinNowak |
tramker
pushed a commit
to tramker/phobos
that referenced
this pull request
Jan 27, 2016
Fix Issue 15263 - DList.insertFront(range) regression Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As createNode was taking a value by ref, Dlist.insertFront could not be
called with a range with a non-ref front.
Fix by providing a createNode overload to use for non-ref values.
Resolves #15263.