Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.json: Encode control characters #3872

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

dcarp
Copy link
Contributor

@dcarp dcarp commented Dec 16, 2015

Currently std.json treats the Unicode control characters asymmetrically: it can decode them, but on encoding it throws an exception.
This PR implements the control character encoding similarly to other JSON libraries (ex. python)

@Hackerpilot
Copy link
Member

Auto-merge toggled on

Hackerpilot added a commit that referenced this pull request Dec 18, 2015
std.json: Encode control characters
@Hackerpilot Hackerpilot merged commit 7764b50 into dlang:master Dec 18, 2015
@JackStouffer
Copy link
Member

@dcarp can you make a PR to update the changelog informing people of this new functionality?

@dcarp dcarp deleted the json_encode_control_char branch December 19, 2015 09:17
@dcarp
Copy link
Contributor Author

dcarp commented Dec 19, 2015

@JackStouffer I just added #3881

MartinNowak added a commit that referenced this pull request Jan 2, 2016
@CyberShadow
Copy link
Member

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=17555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants