Add medianOfMedians #3938
Closed
Add medianOfMedians #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andralex
force-pushed
the
medianOfMedians
branch
5 times, most recently
from
43a1244 to
b1bed39
Compare
| assert(notGreater >= 0.3 * v.length); | ||
| assert(notSmaller >= 0.3 * v.length); | ||
| } | ||
|
|
There was a problem hiding this comment.
Needs tests using std.internal.test.dummyrange
There was a problem hiding this comment.
Also needs tests that use a custom less
andralex
force-pushed
the
medianOfMedians
branch
2 times, most recently
from
f70f461 to
72b2a7c
Compare
andralex
force-pushed
the
medianOfMedians
branch
from
72b2a7c to
9e004c3
Compare
|
Awesome! This can be implemented for immutable ranges using a deep recursion. @andralex would you mind I create PR to your fork? |
|
I think I better get to implement the MoM with integrated partition first. Will get back to this. |
andralex
force-pushed
the
medianOfMedians
branch
from
a0635de to
48080db
Compare
|
I'll reiterate my comments that were hidden due to the new commit:
|
…ianOfMediansPartition
andralex
force-pushed
the
medianOfMedians
branch
from
48080db to
27cf1f4
Compare
|
@JackStouffer agreed, will get to that soon. For now performance is just awful. |
| private void medianOf5(alias less, Range)(Range r) | ||
| { | ||
| assert(r.length == 5); | ||
| enum : uint { a, b, c, d, e } |
There was a problem hiding this comment.
this enum feels strange, especially as there is nothing similar in the next function.
|
new work to come to this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a famous and very elegant algorithm. In addition, the implementation is a beauty.