make parse with radix work on ranges (bugzilla 7302) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is almost same as a part of #298, it is my pull request. I can argue that this is the right way. |
|
Now pull tester fails with following errors: |
added 3 commits
January 19, 2012 09:00
Including the full input is not feasible with non-forward ranges. And with infinite ranges it leads to an infinite loop.
|
Those warnings save the day. I had missed that infinite ranges lead to an infinite loop on error message generation (as has whoever changed parse() without radix to accept ranges). |
9rnsr
added a commit
that referenced
this pull request
Jan 19, 2012
make parse with radix work on ranges (bugzilla 7302)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.