New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5718 - Can't demangle symbol defined inside unittest block #414

Merged
merged 1 commit into from Feb 1, 2012

Conversation

Projects
None yet
3 participants
@9rnsr
Member

9rnsr commented Feb 1, 2012

http://d.puremagic.com/issues/show_bug.cgi?id=5718

std.traits.mangledName should return valid mangled name against symbols in function.

Issue 5718 - Can't demangle symbol defined inside unittest block
std.traits.mangledName should return valid mangled name against symbols in function.
else
{
enum string mangledName = sth[0].mangleof;
}
}

This comment has been minimized.

@donc

donc Feb 1, 2012

Collaborator

Just as an aside, I'm certain that I wrote the original version of that code. It was originally called "mangleNameOf", and was published on the ng and in DDL project on dsource. Somebody copied it verbatim and republished it another dsource project with my name removed and most of the comments stripped out, but with the function names unchanged. I think this code is based on that. This code still doesn't include the comments explaining why it works, and it really needs to. It took a lot of creativity to come up with, it's really not obvious.

@donc

donc Feb 1, 2012

Collaborator

Just as an aside, I'm certain that I wrote the original version of that code. It was originally called "mangleNameOf", and was published on the ng and in DDL project on dsource. Somebody copied it verbatim and republished it another dsource project with my name removed and most of the comments stripped out, but with the function names unchanged. I think this code is based on that. This code still doesn't include the comments explaining why it works, and it really needs to. It took a lot of creativity to come up with, it's really not obvious.

@WalterBright

This comment has been minimized.

Show comment
Hide comment
@WalterBright

WalterBright Feb 1, 2012

Member

Don, please add your explanatory comments & credit back in (in a separate pull, as I'm pulling this one now).

Member

WalterBright commented Feb 1, 2012

Don, please add your explanatory comments & credit back in (in a separate pull, as I'm pulling this one now).

WalterBright added a commit that referenced this pull request Feb 1, 2012

Merge pull request #414 from 9rnsr/fix5718
Issue 5718 - Can't demangle symbol defined inside unittest block

@WalterBright WalterBright merged commit ac88792 into dlang:master Feb 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment