Make all toImpl overloads private

[JackStouffer]

http://forum.dlang.org/post/hapxiqrdmjdiavqlpzlv@forum.dlang.org

[ghost]

after a check the documentation generated becomes more confusing:

• template to(T) , the to function...: what ? function ? template ?
• from type Source to type Target: it's a template with a single parameter named T.

one solution is to write the doc in a version(D_Ddoc){} block, as it is already done here and there in phobos.

version(D_Ddoc)
{
    /// the ddoc and the declaration used to generate the doc. 
    Target to(Target, Source)(Source source);
}
else
{
    // the real content
}

[schuetzm]

There are now lots of instances of "to" that need an "_" added, because Ddoc makes them bold otherwise.

Also, not directly related to this PR, but IMO the examples in the documentation would profit from UFCS to make them more readable.

[JackStouffer]

@bbasile @schuetzm Addressed comments

[JackStouffer]

@MartinNowak Is this breakage acceptable?

[ghost]

Thanks for listening although I would have prefered the cheat indicated earlier with D_Ddoc. Anyway ok now.

Another thing: there was an old enhancement request that was closed recently (handling of hex prefix in this function). Could you add a note here, after the grammar for the unsigned numbers:

For conversion to unsigned types, the grammar recognized is:

    UnsignedInteger:
       DecimalDigit
       DecimalDigit UnsignedInteger

Something like

Note that the specific syntax used for D hexadecimal and binary literals is not handled. Neither the prefixes that indicate the base, nor the horizontal bar used to separate groups of digits are recognized. This also applies to the suffixes that indicate the type.

[JackStouffer]

@bbasile Can you post a link to that bug so I can link to it in the docs?

[ghost]

It's not a bug: https://issues.dlang.org/show_bug.cgi?id=9797.

It's something that won't be done, so the ddoc must specifies that certain forms of literals are not accepted. Thx BTW, I was too lazy to do it myself...

[JackStouffer]

@bbasile I added a note with an example

[ghost]

pure seems to be the origin of the latest auto tester failure. Old UT for AA at line 1096 was not pure !

[DmitryOlshansky]

LGTM

[ghost]

LGTM ✔️

[JackStouffer]

I take back my previous request. If @MartinNowak doesn't like it he can always revert it before the release.

[wilzbach]

LGTM^3 - maybe we should add a small warning to the changelog?

[JackStouffer]

@wilzbach done

[wilzbach]

This branch has conflicts that must be resolved

I assume the changelog file?
Yet another reason for #4228 ;-)

[JackStouffer]

rebased

[JackStouffer]

ping @DmitryOlshansky I think this is good to go

[schuetzm]

There are still tons of bold "to"s:
http://dtest.thecybershadow.net/artifact/website-d6d12c1c1afc9a7a52b48c36a2c67cf74b2cf7ba-10599644e2d3a19f38cc7fdf45b92aaf/web/phobos-prerelease/std_conv.html

[JackStouffer]

@schuetzm I think I caught them all now

[DmitryOlshansky]

Auto-merge toggled on