Issue 5233 - std.range.put accepts *any* element type when putting to an array. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std.range.put accepts *any* element type when putting to an array. http://d.puremagic.com/issues/show_bug.cgi?id=5233 Additions - several additional overloads - output ranges can now recursively call put on themselves by calling put!(R,E,true)(r,e). Changes - char[] and wchar[] are now considered output ranges. Unchanged - Mutable arrays are filled, while immutable arrays are appended.
|
I'm willing to pull this in only as a step towards a complete rewrite. With time put() has become a mess and this request only adds to it. We need to rethink and reimplement what a.put(b) really does and for what kinds of as and bs it works. |
|
rebase please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch primarily adds code snippets to put and adds support for output ranges to recursively call put on themselves and bypassing the r.put code snippets. This lets templated output ranges support all the code snippets in put() without having to re-implement them.
This patch also address issue 4880 - [patch] std.range.put does not handle output ranges implement via opDispatch; breaks on RefAppender
Other Changes
Unchanged
fix issue 5233
http://d.puremagic.com/issues/show_bug.cgi?id=5233
fix issue 4880
http://d.puremagic.com/issues/show_bug.cgi?id=4880